Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow cargo generate version 0.22 #445

Merged
merged 1 commit into from
Sep 9, 2024
Merged

Allow cargo generate version 0.22 #445

merged 1 commit into from
Sep 9, 2024

Conversation

DOBEN
Copy link
Member

@DOBEN DOBEN commented Sep 8, 2024 •
edited
Loading

Purpose

Fixes #442

Changes

Victor-N-Suadicani
Victor-N-Suadicani approved these changes Sep 9, 2024
View reviewed changes
Copy link
Contributor

@Victor-N-Suadicani Victor-N-Suadicani left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one comment on the version. Also the concordium-std/src/lib.rs files seems to trigger some lints.

templates/cis2-nft/cargo-generate.toml Show resolved Hide resolved
@DOBEN
Copy link
Member Author

DOBEN commented Sep 9, 2024

We discussed that the lint warnings in concordium-std/src/lib.rs (which have been there for a long time) are not related to this PR and can be addressed in another PR.

@DOBEN DOBEN merged commit 74d6474 into main Sep 9, 2024
138 checks passed
@DOBEN DOBEN deleted the allow-cargo-generate-0.22 branch September 9, 2024 08:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Victor-N-Suadicani Victor-N-Suadicani Victor-N-Suadicani approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Templates do not build with the latest cargo-concordium cargo generate-generate 0.22.0
2 participants
@DOBEN @Victor-N-Suadicani